vision icon indicating copy to clipboard operation
vision copied to clipboard

Update type annotations to include `pathlib.Path`

Open joshestein opened this issue 1 year ago • 2 comments

Addresses https://github.com/pytorch/vision/issues/2962.

joshestein avatar May 11 '24 17:05 joshestein

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8423

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar May 11 '24 17:05 pytorch-bot[bot]

Hi @joshestein!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar May 11 '24 17:05 facebook-github-bot

Thanks for the PR @joshestein . Unfortunately we cannot add these type annotations because they would break torchscript support, which is a required feature of these functions. That being said, even if we can't add the type annotations, all of those already properly support Path inputs.

NicolasHug avatar May 31 '24 12:05 NicolasHug