Nico

Results 29 comments of Nico

A few people said it during the previous PR and also on Discord, they think it's not a good solution to implement the chat in the admin resource, since quite...

> I think if you are going to go forward with these expanded features it makes sense for it to be in a separate resource. However, I would personally like...

I was only able to reproduce it when I created a lot of buildings at once.

I see that when the error message about running out of slots appears, the game crashes. Otherwise, not really.

@TracerDS Thanks for the suggestions. Although I didn't write this piece of code, I updated it according to modern standards.

I already used early returns in my own modifications, in the previous review I didn't think that you meant to change the returns in the entire function, but I did,...

> Rotation fix is good, but it creates a situation when 2 players see one object with 2 different rotations. We can merge this fix right before the 1.6.1 release...

> That's fine with me too. > Would it be good if I put the fix in a separate PR, so that the new events would be usable sooner? I...

> Why do we need an additional event separately for the player? To match the server side events. This will not break backwards compatibility, because the onClientMarkerHit event is also...

> You would need to fix all the scripts that use `onClientMarketHit` if this solves #3310. If I'm reliable expecting only players and I get, let's say, a vehicle, then...