NickSdot

Results 54 comments of NickSdot

> @jyyi1 are there any guidelines to taking over PRs? (I will of course set a Co-Author) but this issue is starting to bug me more and more. Just fork...

> I honestly am not sure the juice is worth the squeeze here. It's a breaking change that fixes a relatively minor inconsistency but is just one more thing for...

> [@browner12](https://github.com/browner12) unfortunately it would not. With that PR, if `$conditional` is false then this: > > > would output this: > > @willrowe You don't even need what I...

> that's a valid option, but there are scenarios when I may not want to define that behavior in the component itself, and rather allow the calling code to have...

> [@AhmedAlaa4611](https://github.com/AhmedAlaa4611) does this work as well? > > `` > > `` > `` It does. That's what I meant above. ```blade ```

Seems like Browner12 cannot come up with a real world example. Given that two people provided working solutions, and that we want the framework to be clean and maintainable, this...

> I can, but you were obviously upset when you wrote the comments, and I have no interest in committing more energy to this right now. I joined here because...

> I can target `master` if you like @calebdw I am pretty sure you are aware, but in case your are not here a friendly reminder that Taylor doesn't check...

## Fixer Rule Context The PHP CS Fixer `no_superfluous_phpdoc_tags` rule: - has no open issues - had it's last merged PR 16 months ago - is part of popular Fixer...

> @NickSdot how does this align with my comment on the `@maybe` PR? > > > > > Personally I think we should just follow what @timacdonald suggested on this,...