outline-apps icon indicating copy to clipboard operation
outline-apps copied to clipboard
verified publisher icon Jigsaw-Code

fix(client/macos): update macOS Dock hide logic

Open seu1a opened this issue 6 months ago • 5 comments

This PR refactors the Dock hiding logic to improve behavior on macOS (#2510)

seu1a avatar Jun 03 '25 10:06 seu1a

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 03 '25 10:06 google-cla[bot]

Thank you for the review! The code is much cleaner now.

seu1a avatar Jun 12 '25 12:06 seu1a

I removed empty lines for code style consistency

seu1a avatar Jun 12 '25 22:06 seu1a

@fortuna , gentle reminder for a review.

jyyi1 avatar Jun 16 '25 19:06 jyyi1

@seu1a please update the PR description explaining what the new logic is. It's hard to guess based on the code. Thank you.

fortuna avatar Jun 16 '25 23:06 fortuna

Hi @seu1a , could you take a look at @fortuna 's comments and make the necessary updates? Thanks.

jyyi1 avatar Jul 02 '25 22:07 jyyi1

Will this PR also bring the Outline window back to the menu bar? I don't really get why I should have a permanent outline window floating around somewhere.

NickSdot avatar Jul 13 '25 11:07 NickSdot

It has been 2 weeks since last update.

Please finish up ASAP since it's major inconvenience to use the app in MacOS.

khantzawhein avatar Jul 13 '25 20:07 khantzawhein

Hi @seu1a , it's been a while. If you are too busy to update the PR, I'd be glad to take over this.

jyyi1 avatar Jul 14 '25 22:07 jyyi1

Any updates here? This is a very annoying bug

@jyyi1 I don't think you'll get an answer, it's been more than a month, maybe it's time to finish it

ido177 avatar Aug 18 '25 10:08 ido177

@jyyi1 are there any guidelines to taking over PRs? (I will of course set a Co-Author) but this issue is starting to bug me more and more.

Kief5555 avatar Oct 07 '25 02:10 Kief5555

@jyyi1 are there any guidelines to taking over PRs? (I will of course set a Co-Author) but this issue is starting to bug me more and more.

Just fork the feature branch, keep their commits and resubmit. Since this is stale and ignored, it should be fine.

NickSdot avatar Oct 07 '25 02:10 NickSdot

@jyyi1 are there any guidelines to taking over PRs? (I will of course set a Co-Author) but this issue is starting to bug me more and more.

Thanks for offering to help on this! Since this PR has been inactive for a while and has merge conflicts, please feel free to create a new one.

jyyi1 avatar Oct 08 '25 19:10 jyyi1

Close this in favor of:

  • #2649

jyyi1 avatar Oct 15 '25 21:10 jyyi1