Nick Crews

Results 281 comments of Nick Crews

Hey @sebastian-philipp @OnkelTem @rwarren, I took a stab at adding a stub to typeshed. If any of you had time to review that PR (python/typeshed#5248), it would probably be very...

OK, that PR was merged. If I understand correctly, mypy should start including the stub in new versions (I don't understand by what mechanism or how quickly that will happen,...

This looks like a great idea and a good implementation to me.

If it's not too hard, and if you point me to where you want it, I can add a test for this regression. Thanks!

Thank you for the responses. That makes sense that we can't rely on order, darn. And I would see how if we need to download the whole file then skipping...

This looks great @h4l, but let's wait for #36 to merge so we can then rebase on top of that?

Eh I just tried to fix the merge conflicts in the Web UI and it doesn't look that good, do you think you could actually do a rebase locally and...

Excellent work @h4l ! I'm going to add the isort-ing now. Didn't want to add before and cause more merge conflicts.

Hey @h4l, thanks for the great bug AND inspection AND fix. Sorry I didn't see this earlier. At first read that solution seems great. I'll look into this more sometime...

@blaisep this is really late, but perhaps you or someone else still is motivated. I would totally merge this if it comes together fairly cleanly. I took a look at...