asv icon indicating copy to clipboard operation
asv copied to clipboard

BUG: Allow branches that conflict with file names

Open NickCrews opened this issue 3 years ago • 1 comments

Before, if I had a file named "benchmarks" and a branch specified in asv.conf.json also named "benchmarks", then when I ran asv publish I would get

$ asv publish
[ 11.11%] · Loading machine info
[ 22.22%] · Getting params, commits, tags and branches
[ 22.22%] ·· Error running /usr/local/bin/git rev-list --first-parent benchmarks (exit status 128)
             STDOUT -------->
             
             STDERR -------->
             fatal: ambiguous argument 'benchmarks': both revision and filename
             Use '--' to separate paths from revisions, like this:
             'git <command> [<revision>...] -- [<file>...]'

Traceback (most recent call last):
  File "/Users/nickcrews/Documents/projects/dedupe/.venv/bin/asv", line 8, in <module>
    sys.exit(main())
....

Tested locally, it works fine now.

NickCrews avatar May 02 '22 19:05 NickCrews

If it's not too hard, and if you point me to where you want it, I can add a test for this regression. Thanks!

NickCrews avatar May 02 '22 19:05 NickCrews

Still missing a test ...

mattip avatar Apr 30 '23 03:04 mattip

If you're familiar with it, could you point me to where exactly you want me to add the test? I can dig around but I'm not at all familiar with this codebase.

NickCrews avatar Apr 30 '23 05:04 NickCrews

Should be good to go now @mattip.

HaoZeke avatar May 13 '23 20:05 HaoZeke

Thanks @NickCrews, @HaoZeke

mattip avatar May 21 '23 07:05 mattip

Thank you for finishing this up, I really appreciate it!

NickCrews avatar May 22 '23 17:05 NickCrews