Nick Crews

Results 425 comments of Nick Crews

> what's the default? i think it makes sense that you have to toggle on index predicates I agree, by default don't use index predicates > not all variable types...

You know you can run these benchmarks locally, right? That might help with any sort of debugging that you need to do. Look at the workflow to see what to...

It's saying stuff about architecture not supported, what architectures are you on? Perhaps because you're on an M1? Not that I know how to fix that, but it might be...

I'm not sure the exact algorithm that levenshtein-search uses, but perhaps it would be worth investigating using https://github.com/mammothb/symspellpy. For edit distances larger than ~2, symspell starts to become algorithmically much...

I think this is a very good motivation for #991

Using a StaticDedupe object and calling `partition()` on it, otherwise vanilla except I monkeypatched in one of the classifier.coef_ values to be -1000 because I have one custom variable that...

Yeah it looks like only the test got added, the actual fix wasn't included. Maybe there was a merge conflict and it was resolved incorrectly. OK after thinking more, I...

Sounds good, so let's not deal with it in cluster, but add a comment that callers are responsible for removing any 0 scores. Take a look at the [test](https://github.com/dedupeio/dedupe/blob/14521e44b0094b3cd85eee41d3f0f9d32be4ef54/tests/test_core.py#L82-L105), it...

> com port can only open once, you import send.py in receive.py,so,when you run receive.py,send.py is already open com ports. I don't think that is true. The port is only...

> I would recommend the use of the logging module instead as it has a wide range of options and levels of granularity. I agree, as `serial` is a library,...