Nick Crews
Nick Crews
hey @gforsyth can you give this a review when you get the chance? Thanks!
@jcrist you all do the rebase and merge, right? Not squash?
Sorry, this is very much a WIP, should have marked it as such. Added a very basic description to the OP.
@cpcloud just to be clear, currently `ibis.array([1, None, 2]).remove(2)` results in `[1]`. In this PR I just want to fix it so this results in `[1, None]`. Were you thinking...
Yup that's my bad for a vague PR title and no description (I edited it to be more clear after I saw your confusion, you're not being gaslit here, it...
Thanks @cpcloud for finishing this up!
Would changing `ibis.ifelse(table_expr[name], 1, 0).cast("boolean")` to something like `ibis.case().when(x.isnull(), ibis.null()).when(x, 1).else_(0).end()` be the right direction?
Ok, to be honest I don't use mssql so I'm not motivated to fix this myself. Feel free to close or move to backlog or whatever you think is best....
in my first attempt at https://github.com/ibis-project/ibis/pull/8649, [I went about it the wrong way](https://github.com/ibis-project/ibis/commit/6925c908122174cd3e6690b50aa2777b6b6463d1#diff-d50c70a1d9c6f811ab5dba8574dbb12647c81ced87d539b19f5517ec037eca9eR495-R496), but I needed to ensure something was an Array, but the incoming thing might already have been...
OK, as I added those tests I found some problems, and this snowballed into also being a fix for https://github.com/ibis-project/ibis/issues/8289. The implementations for both of these things are somewhat intertwined....