ibis icon indicating copy to clipboard operation
ibis copied to clipboard

fix: convert the uint64's from some backends' hash() to the desired int64

Open NickCrews opened this issue 9 months ago • 1 comments

fixes https://github.com/ibis-project/ibis/issues/9135

I don't love the logic that does the conversion. It seems more complicated than it needs to be, and I don't like how I had to implement it once for each backend, but maybe there is no universal way to do this. If you can think of a cleaner way to do this or sidestep the need entirely that would be awesome

NickCrews avatar May 06 '24 21:05 NickCrews

Hey @NickCrews -- I think the exasol failure is fixed on main if you want to rebase this

gforsyth avatar May 08 '24 17:05 gforsyth

hey @gforsyth can you give this a review when you get the chance? Thanks!

NickCrews avatar May 16 '24 15:05 NickCrews

@jcrist you all do the rebase and merge, right? Not squash?

NickCrews avatar May 16 '24 17:05 NickCrews

Depends on the commits and the desired changelog entries (multiple user facing changes would need multiple commits to note). Since this is only 1 commit and change, either works tbh.

jcrist avatar May 16 '24 18:05 jcrist