Nick Colley
Nick Colley
@igloosi can you explain what you mean? The commit you linked to doesn't make it clear why that does not work.
Seems like a robust solution is very code heavy which would not be suitable for clientside. I think Dave's suggestion of leaving it as is but documenting how it works...
This issue is related so changing how we detect changes could fix two issues: https://github.com/alphagov/govuk-frontend/issues/1028 It's also worth noting that custom elements (web components) cover these sorts of cases.
Also related: https://github.com/alphagov/govuk-frontend/issues/1530
I [spiked the idea of using Object.defineProperty to watch value](https://github.com/alphagov/govuk-frontend/commit/b199fec86c27a511f95a33054b829ff3bdbc7353) and it seems to work but I don't know how much of a good idea it is, feels risky. I've...
@nickcolley to look into other approaches for another hour.
@DevRCRun yes you're correct, for now you can't do that with the Nunjucks macro and will need to use HTML directly instead.
Just so you know one limitation of jest-axe is that it runs using JSDOM so checks like colour contrast checks do not work. Moving towards something where a real browser...
I think unless there's a really compelling way to opt into a real browser environment I'd not change jest-axe. Instead my gut feeling it's better to pick a good orchestration...
Hey Emma, We recognise that the api for this component is inconsistent with the rest of our components. To make it consistent we'd need to make a breaking change. For...