Nick Colley

Results 220 comments of Nick Colley

@alexbishop1 are you still interested in getting this done? Feel free to catchup with us if you need any help getting this merged.

This is a good article talking about debounce functions that you can get a function from to use: https://web.archive.org/web/20190112051125/https://remysharp.com/2010/07/21/throttling-function-calls/ ```javascript function debounce(fn, delay) { var timer = null; return function...

I work on the team that maintains this component just as a disclaimer. I personally think that this component should stick to solving the problem of how to display results...

See also: Digital Marketplace's approach to tables: http://alphagov.github.io/digitalmarketplace-frontend-toolkit/summary-table.html

See Tijmen's look into this from a Ruby perspective: https://github.com/alphagov/govuk_publishing_components/pull/337

Another look into how our tables are being integrated into GOV.UK Publishing Components: https://github.com/alphagov/govuk_publishing_components/pull/531/files#r219539033

I was on Linux, with Google Chrome, using Dark mode. It may be some weirdness with CSS Custom Properties perhaps. Hmm. I believe there are similar issues with the light...

Want to get this going to ensure when we resolve contrast issues we dont accidentally regress so adding to milestone for WCAG compliance.

Yeah some things you want to try and aim for AAA but sometimes it's actually impossible to meet all to AAA. AA is what the main legislation for the EU...

Just a note on false positives, it's pretty common for axe to throw up issues that are false positives so what we'd do in this case is disable the rule...