terronator

Results 13 comments of terronator

What's the difference between `to` and `href` in this component? And how are they supposed to work together?

So we are assuming that, if the user passes the `to` prop, then the LinkListItem `tag` is a `react-router-dom` Link element that accepts a `to` prop? React Router is not...

I don't think that the `tag` can accept any React Element, it's an ElementType, so it can be something like `h1`, `p`, not a react router Link element nor any...

You are correct, it does work this way, but in this case the `to` prop is no longer transparent as you said it should be (and I agree), and you...

I made a few tests, and passing the `to` prop down to the `Tag` element like this: ![image](https://github.com/italia/design-react-kit/assets/1497044/60e4e5c1-2647-48e9-ab65-2c806838872f) does not do the job, since the generated html is: ![image](https://github.com/italia/design-react-kit/assets/1497044/97350fc6-ce03-4ab5-b114-42dce34f4246) We...

> Thank you for testing it out @Nick87 > > Do you agree with @ewedlund removing 'to' property as suggested by the PR and using only href with a proper...

> Sorry @Nick87 @ewedlund I'm on holidays atm I can only interact with my phone, not the best to look at the code :) anyway I understood the problem and...

@ewedlund is definitely right and what I suggested earlier does not work since it causes a full page refresh, but I may be on to something that seems to be...

I don't think we can use with `LinkListItem` the same approach as `Select`, since here we are trying to add a prop that does not correspond to a standard html...

> but I need to be able to pass `required` and `value` (and `multiple` but that does not seem to work in terms of visualization) @ewedlund take a look at...