Niklas Saari comments

Results 127 comments of


                                            Niklas Saari

chore: clippy pendantic fixes

Especially APER seems to have some dead code in tests with commented code. Uncommented code fails tests, not sure if those should be looked into. For now, dead code is...

OER encoder produces output that it can't decode

Seems like this bug is triggered because the `rasn_smi::v2::ObjectSyntax` has nested untagged Choices. I am not sure how I should fix this, since there is no single truth for encoding...

OER encoder produces output that it can't decode

This was all I could find related to this: From OER standard: > 20.1 The encoding of a value of a choice type shall consist of the encoding of the...

OER encoder produces output that it can't decode

Here is an example of ambiguous case: ```asn OuterChoice ::= CHOICE { a INTEGER, b InnerChoice } InnerChoice ::= CHOICE { c INTEGER, d BOOLEAN } ``` In both cases...

OER encoding rountrip confuses fields

Thanks for the issue! I think this is related to issue #258 as there is also untagged choice present.

wromg byte order for Integer::to_unsigned_bytes_be

I think the current functionality is correct? 260 as big-endian is `[0b0000_0001, 0b0000_0100]` (256 + 4). MSB in the lowest memory address.

wromg byte order for Integer::to_unsigned_bytes_be

The function currently works maybe a bit differently than one might expect. It is supposed to be used with the another tuple value which returns the amount of needed bytes...