rasn icon indicating copy to clipboard operation
rasn copied to clipboard

chore: clippy pendantic fixes

Open Nicceboy opened this issue 9 months ago • 1 comments

Fixes some clear clippy pedantic suggestions but not all of them.

Nicceboy avatar Apr 07 '25 08:04 Nicceboy

Also allows following lints:

#![allow(
    clippy::missing_errors_doc,
    clippy::float_cmp,
    clippy::no_effect_underscore_binding,
    clippy::items_after_statements
)]

Should we start collecting some lints in Cargo.toml for workspace level?

Nicceboy avatar Apr 07 '25 08:04 Nicceboy

Thank you for your PR! sorry for the delay on this one, would be able to re-open it / resolve conflicts?

XAMPPRocky avatar Aug 01 '25 07:08 XAMPPRocky

I made rebase but there seems to be other issues. Is rust-toolchain file still relevant or can we remove it? It seems to now override in general everything.

Nicceboy avatar Aug 02 '25 18:08 Nicceboy

Especially APER seems to have some dead code in tests with commented code. Uncommented code fails tests, not sure if those should be looked into. For now, dead code is allowed, which failed the CI.

Nicceboy avatar Aug 02 '25 19:08 Nicceboy

Thank you for your PR!

XAMPPRocky avatar Aug 06 '25 13:08 XAMPPRocky