Nezisi

Results 13 comments of Nezisi

@lmenezes Branch is ready for pull now.

Hi @lightbend-cla-validator CLA is signed

I think it would be better to make SBT 1.8 mandatory for Play 2.9. SBT 1.8 fixed a lot of critical bugs, plus the improved Scala 3 support and the...

That sounds like a really good plan. Sorry, I misunderstood the bug report, it sounded like you wanted to keep the pre SBT 1.9 support alive for 2.9 .

@ihostage Hello :) Thanks for your work, too! Wouldn't mind porting later to AssertJ - though I strongly suggest doing it in a separate PR. A lot of the calls...

Last commit splits the play-test package into 3 separate projects: - play-test-project itself ⇒ Scala Code + Non JUnit-specific classes like TestBrowser / TestServer / Helpers - play-test-junit4 ⇒ JUnit...

I've migrated the documentation, sorry it took so long. There is one part in the documentation validation that I cannot wrap my head around, sadly. https://github.com/playframework/playframework/blob/96cbacedea861e681b46bbdb2f3d1f8c58960c65/dev-mode/play-docs-sbt-plugin/src/main/scala/com/typesafe/play/docs/sbtplugin/PlayDocsValidation.scala#L424 The validation plugin *seems*...

At long last, this should cover all the necessary grunt work to be on JUnit 5. There is a lot of room for improvement, for example the suggestion of @ihostage...

Just to be clear - sorry for being pedantic - so Digma doesn't call home by any means, nor does it utilize the data (be it anonymized or not) it...

@ihostage Thank you for the Gradle plugins. :) https://github.com/Nezisi/play-twirl-scala-vs-java-sourceset I added a README.md where I tried to execute all my commands with gradle --info switch.