Augustin Husson

Results 178 comments of Augustin Husson
trafficstars

> @LeviHarrison That would be interesting, we could possibly pull a `prometheus.Describe()` to get the metric TYPE/HELP list. if at some point we would like something a bit less home...

yeah that's the risk to go with React, it won't be that simple anymore and as a side effect potentially the binary size increase more than what we would like...

so It's a trade off. It's just if at some point we want that involved javascript for example we should go with React. Until that, we should be good with...

> We should avoid the generate assets and use embed. Ah yeah I forgot about that everytime.

looks definitely better with `embed` !!

this PR can be closed as the logo has been added thanks to the PR https://github.com/thanos-io/thanos/pull/6264 :)

I also think it will simplify the way to manage AM. Of course we can use the API or the `amtools`, but as a kubernetes user, it is nicer to...

@brancz does it makes sense what I said above ? If by any chance it's 'ok', I will be glad to do it if you want.

Oh yeah that's already cool to have this option ! Thank you for pointing it, I didn't pay enough attention to the documentation. I still think it would be cool...

ah nice, thanks for the pointer ! I will look there then :).