thanos
thanos copied to clipboard
thanos-io
Added logo
Signed-off-by: soumya [email protected]
- [ ] I added CHANGELOG entry for this change.
- [ ] Change is not relevant to the end user.
Issue #5121
Changes
Added logo
Verification
Tested locally
UI Screenshot
Soooo after talking a bit with @matej-g, it appears that the issue regarding the doc is tracked with https://github.com/thanos-io/thanos/issues/4732 and there is a short fix with https://github.com/thanos-io/thanos/pull/5167.
So I would suggest that you revert the changes related to the doc @tend2infinity in this PR. Hopefully once #5167 is merged, the CI in this PR will be green.
you still have to run make assets and commit the file changed @tend2infinity ;)
cool, now we are good @tend2infinity, thanks !
back to you guys @kakkoyun @metalmatze :)
ah no wait, you have some conflict @tend2infinity. Probably better to rebase the PR with the last changes from the main branch and then re-run make assets
ah no wait, you have some conflict @tend2infinity. Probably better to rebase the PR with the last changes from the main branch and then re-run
make assets
Yup, I rebased, I feel now we should be good to go
It looks like the file bind_data.go isn't well generated or formated. Did you get an error when running the command @tend2infinity ?
@tend2infinity could you rebase on main? Docs are building correctly there and there were done changes recently
@tend2infinity if you are not available anymore, I could take back your PR and rebase it if you want, so we can merge it :).
Hey @Nexucis really sorry couldn't catch up, actually have my exams right now, will update this as soon as I get time
Its been a while since I looked upon this issue and right now um facing a lot of conflicts while rebasing the branch, maybe we can close this issue and open a clone of this and make the same changes in a new branch
if it's too hard to rebase, maybe you could simply merge the main branch in yours.
And if the conflicts are still too hard to resolve, another way around to do it, is to erase your local branch with the last commit from the main branch. And then copy and past the changes you can find in this PR. Commit your changes, and force push. So it doesn't change the branch and so the PR.
if it's too hard to rebase, maybe you could simply merge the main branch in yours.
And if the conflicts are still too hard to resolve, another way around to do it, is to erase your local branch with the last commit from the main branch. And then copy and past the changes you can find in this PR. Commit your changes, and force push. So it doesn't change the branch and so the PR.
Done exactly the same, I guess it must be fixed now
if someone from the thanos team can rerun the github action, it will hopefully work :). And then probably it will be the good time to merge if you are agree too ;)
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
yes it is still relevant, but I have no idea why it has not been merged. Perhaps there was still a blocking point
Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.
Hi @tend2infinity, are you still planning to finish this pr? If not, I am happy to help resolve the merge conflict and get this in!
Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.
this PR can be closed as the logo has been added thanks to the PR https://github.com/thanos-io/thanos/pull/6264 :)