Dickson Tan

Results 151 comments of Dickson Tan

Is this change documented in the changelog anywhere? I'm trying to find where this was added but don't see any mention of this in the Beets or Mediafile changelog. Using...

I found https://github.com/beetbox/mediafile/pull/82 introduced the change, released in Mediafile v0.14.0. This is used in https://github.com/beetbox/beets/pull/5696 I won't be fixing this for now. There doesn't seem to be a way for...

@Zarel yup aria-hidden does the trick. Originally thought about fixing the entire issue in a single PR, but I think the improvements I've made to the battle interface improves the...

Which menus do you mean? The main menu (with home etc), or the menus that appear (e.g to choose a format)?

@Zarel is there an easy way for me to be signed in in 2 places simultaneously so I can leave the battle window open without havinig to actually conduct a...

Moving focus would be a perfect solution for the battle format menus. When the menu is dismissed (e.g with escape key), focus should also be restored to where it was...

For sliders, why not the [html5 input element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/range)?

Is the [compatibility table here on MDN on `` support](https://developer.mozilla.org/en/docs/Web/HTML/Element/input) accurate? If so, then input looks to be well-supported bar things like date pickers.

@Zarel noted. Thanks for all the help on this issue, appreciated :)

There've been debates around whether allowing screen reader detection is a good idea, and [this article explains why I oppose it](https://www.marcozehe.de/2014/02/27/why-screen-reader-detection-on-the-web-is-a-bad-thing/). I suggest adding `role="complementary"` and an appropriate `aria-label="..."` around...