Alexander Neumann

Results 375 comments of Alexander Neumann

will draft the PR until cmake 3.24 is out

@dg0yt Which log do i actually need to look at for the cmake-user failure?

@dg0yt: yeah the error is that the check is trying to also check `windows.cmake` for 3.7.2 compat which is unnecessary since that is completely internal.

> How can you say it is internal? It is the toolchain used by users, externally. That's the point of this test. `vcpkg.cmake` is external; `windows.cmake` is not. The error...

@dg0yt simply overwrite the value or try to merge the two files in the portfile.

@dg0yt: Also is gettext maybe not using `AC_CONFIG_SUBDIRS` and running configure manually in the subdirs?

@dg0yt In the gettext case I would probably add `NO_CONFIGURE_CACHE` and deal with the merging of options within the portfile. (Simply moving the `VCPKG_MAKE_CONFIGURE_CACHE` to the file location `gettext` internally...

He is just saying I should skip merging this PR with master until all the other WR PRs have been solved.

@dg0yt I think the MS team hasn't decided to merge this approach yet? So it probably doesn't make sense to block the bugfix on this PR.

> I think we should go through the configuration process completely every time instead of using a cache that might contain problems? a) it doesn't make sense to always run...