Alexander Neumann

I updated HPX in vcpkg to 1.8.0 a week ago. What I see is: ``` set_target_properties(HPX::compression_bzip2 PROPERTIES INTERFACE_LINK_LIBRARIES "HPX::hpx;${VCPKG_IMPORT_PREFIX}/lib/bz2.lib;Boost::iostreams" ) ``` Is wrong. Should look like: ``` set_target_properties(HPX::compression_zlib PROPERTIES INTERFACE_LINK_LIBRARIES...

` target_compile_definitions(hpx_private_flags INTERFACE "$" )` If you don't want to use generator expressions due to questionable reasons you need to apply an indirection decoupling that setting from `CMAKE_BUILD_TYPE` correctly, e.g....

> Where do you see that? Will be fixed by #5904. Is due to the outdated bzip2 module which misses the bz2d debug library.

What exactly was the error before? Were they of this kind? ``` [build] [5/5] Linking CXX executable testing-grounds\tg-testing-hpx.exe [build] FAILED: testing-grounds/tg-testing-hpx.exe [build] cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E...

> target name It is not the target name but the output name / output path which clashes on windows. The target name is different but the output is the...

> Historically When was that? When the x86 toolchain was still the default? (Could have switched to the x64 toolchain) I mean hpx is probably not larger than vtk with...

to document the error: ``` CMake Error: Running '/usr/local/bin/ninja' '-C' '/Users/vagrant/Data/buildtrees/hpx/x64-osx-dbg' '-t' 'recompact' failed with: ninja: error: build.ninja:29840: multiple rules generate lib/libhpx_memoryd.a [-w dupbuild=err] ```

> Unfortunately I am not familiar with vcpkg and overlay ports. any way I will have a look in to it. is this a private repository ? bcoz I am...

> Possible workaround that I can't test until I have autoconf working with MSVC: - Run the batch setting up vsvars - open a msys bash - make sure /usr/share/automake-1.16...

> Tagged reviewed so other members will review this changes (doesn't means approved). As soon as CMake 3.24 gets released parts of this PR can be dropped. I'll update CMake...