Alexander Neumann
Alexander Neumann
And yes `z_vcpkg_setup_pkgconfig_path(BASE_DIRS "${CURRENT_INSTALLED_DIR}")` is terrible. It should have been `z_vcpkg_setup_pkgconfig_path(CONFIG )` and abstracted away passing in any paths at all.
Evennif CMake deprecates it FindVulkan still needs to be supported by vcpkg due to not everybody updating to latest cmake
> I'm suggesting to remove the find_package(Vulkan) check from vcpkg and not try to fix what is broken already upstream. Therefore also not adding any wrapper to make glslang 14.0.0...
From the call in the log ``` "-DFEATURE_freetype=ON" "-DINPUT_freetype:STRING=system" ``` ``` ERROR: Feature "fontconfig": Forcing to "ON" breaks its condition: NOT WIN32 AND QT_FEATURE_system_freetype AND Fontconfig_FOUND Condition values dump: WIN32...
@dg0yt Any idea why `vcpkg-find-acquire-program` is failing or why it does a double extraction (at least that is what I assume)? Is the search path wrong? Should the test port...
> I guess the problem is related to the fact that vfap is unable to parse the version from the program's output, and that's why it even doesn't accept its...
Should I retrigger CI or should i wait for further review?
I'll vote for removal. Stuff like this can be set via `VCPKG_CMAKE_COINFIGURE_OPTIONS` or the port needs to inspect compiler flags to enable those.
But it is also totally unnecessary to remove it. > If this variable is overridden by the projects, setting it to a non-debug runtime library, we'd still have the explicitly...
> within compiler-rt, specifically wants to link with the static, non-debug runtime, so it does set(CMAKE_MSVC_RUNTIME_LIBRARY MultiThreaded) Just patch that line out. I assume compiler-rt only cares about Release builds.