vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

Refine rpath fixup to inspect already existing rpaths

Open Neumann-A opened this issue 2 years ago • 7 comments

Reason:

-- Adjusting original rpath of: '/mnt/e/all/vcpkg/installed/x64-linux-release/lib/pkgconfig/../../lib/intel64/'
-- Fixed rpath in: '/mnt/e/all/vcpkg/packages/numpy_x64-linux-release/lib/python3.11/site-packages/numpy/linalg/lapack_lite.cpython-311-x86_64-linux-gnu.so' ('$ORIGIN:$ORIGIN/../../../../:$ORIGIN/../../../../intel64/')

needed $ORIGIN/../../../../intel64/ in there which came from a pc file via -Wl,-rpath='${libdir}'

Neumann-A avatar Jan 05 '24 21:01 Neumann-A

/azp run

Cheney-W avatar Jan 08 '24 09:01 Cheney-W

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 08 '24 09:01 azure-pipelines[bot]

@dg0yt Any idea why vcpkg-find-acquire-program is failing or why it does a double extraction (at least that is what I assume)? Is the search path wrong? Should the test port search for everything twice?

Neumann-A avatar Jan 14 '24 19:01 Neumann-A

I guess the problem is related to the fact that vfap is unable to parse the version from the program's output, and that's why it even doesn't accept its own previous download. Cf. #36046.

dg0yt avatar Jan 14 '24 19:01 dg0yt

/azp run

Cheney-W avatar Feb 02 '24 09:02 Cheney-W

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 02 '24 09:02 azure-pipelines[bot]

I guess the problem is related to the fact that vfap is unable to parse the version from the program's output, and that's why it even doesn't accept its own previous download. Cf. https://github.com/microsoft/vcpkg/issues/36046.

Nope was a problem with the test. It simply set the variable to empty resulting in unexpected behavior

Neumann-A avatar Feb 04 '24 19:02 Neumann-A

/azp run

Cheney-W avatar Feb 18 '24 07:02 Cheney-W

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 18 '24 07:02 azure-pipelines[bot]

Should I retrigger CI or should i wait for further review?

Neumann-A avatar Feb 21 '24 14:02 Neumann-A

/azp run

Cheney-W avatar Feb 22 '24 07:02 Cheney-W

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 22 '24 07:02 azure-pipelines[bot]