Alexander Neumann
Alexander Neumann
> In my opinion all packages with X_VCPKG_FORCE_X_LIBRARIES should be empty libraries, and instead of controlling behavior through a triplet variable it should be done through an overlay. > Maybe...
The above being said: The current approach has one benefit since you could add additional messaging or testing if the libraries provided by the system actually is provided by the...
> "X" PRs because it leaves these ports completely untested. Yeah, I didn't want to force a world rebuild for this one by adding the variable to the linux triplet....
@BillyONeal The ports were tested in [4801462f8c9c723c178a2e4ee9de65c883d69f5c](https://dev.azure.com/vcpkg/public/_build/results?buildId=79659&view=logs&jobId=afe306fb-88a0-5d5e-2934-71aa01507316): linux/osx green
you might want to fix https://github.com/google/snappy/blob/af720f9a3b2c831f173b6074961737516f2d3a46/CMakeLists.txt#L113-L115 instead
> These variables are used only when SNAPPY_BUILD_TESTS is enabled, no action needed. Ok was wondering why nobody noticed that yet ;)
Also this is a problem for MSVC since it allows compiling intrinsics without the required flags. clang-cl will fail the `check_cxx_source_compiles` check without the required flags.
@wrobelda Could you please fix/revisit the kf5 dependencies? (explicitly disabling dependencies on windows) kf5globalaccel fails due to: ``` -- Configuring done CMake Error at C:/a/1/s/scripts/buildsystems/vcpkg.cmake:578 (_add_library): Target "KF5GlobalAccelPrivate" links to...
> I see that you fixed it already. Anything else is needed? did not really fix the problem the problem is coming from somewhere else > BTW, if you also...
@ras0219-msft: More infos here: https://commons.wikimedia.org/wiki/Category:Wayland_diagrams https://blogs.igalia.com/itoral/2014/07/29/a-brief-introduction-to-the-linux-graphics-stack/ But the bigger problem is to fix the already exisiting ports not depending on the x ports.