Netanel Basal comments

Results 277 comments of


                                            Netanel Basal

FormArray of array element does not work properly

You're welcome to create a PR.

Integrate with Angular 14 typed forms

It's not exactly the same. Angular doesn't have the ControlsOf helper, for example.

Fix ObjectUnsubscribedError

@marcelriegr, can you give me an example for this use case, please?

[Feature Request] change GitHub secret name for deploy GitHub Action

Why do you need the deploy.yml?

[Feature Request] change GitHub secret name for deploy GitHub Action

Opps wrong repo :)

chore(github): move existing template to new issue forms format

There is no need to close it. We'll merge it when the feature will be prod ready. Thanks!

Prevent the change of query params when a form is invalid

Seems reasonable to me. You're welcome to submit a PR.

Prevent the change of query params when a form is invalid

I think we should allow it in the following cases: - globally - manager instance - def

Feature Request - Add option to handle back button in the browser

By default, we use the `replaceUrl: true` as you can see [here](https://github.com/ngneat/bind-query-params/blob/master/projects/ngneat/bind-query-params/src/lib/BindQueryParamsManager.ts#L112). I don't mind seeing a PR that makes it configurable.

feat(lib): allow to add custom storage

Thanks for the PR. Can you update the docs, please?