forms-manager icon indicating copy to clipboard operation
forms-manager copied to clipboard

feat(lib): allow to add custom storage

Open va-stefanek opened this issue 3 years ago • 8 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] The commit message follows our guidelines: https://github.com/ngneat/forms-manager/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [X] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently we can only use localStorage as a persistence storage

Issue Number: #6

What is the new behavior?

We can use any persistence storage which extends proper interface

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

va-stefanek avatar May 26 '21 17:05 va-stefanek

Thanks for the PR. Can you update the docs, please?

NetanelBasal avatar May 27 '21 05:05 NetanelBasal

@NetanelBasal Done.

va-stefanek avatar May 27 '21 06:05 va-stefanek

Any updates on this feature? This is very important!

AdmilsonCossa avatar Jul 08 '21 05:07 AdmilsonCossa

@AdmilsonCossa I will try to complete this by the end of the week.

va-stefanek avatar Jul 08 '21 07:07 va-stefanek

@va-stefanek looking for your update sir :D

hiepxanh avatar Sep 16 '21 10:09 hiepxanh

@NetanelBasal let me know if we are still interested in that feature, whether we should remove FORMS_MANAGER_SESSION_STORAGE_PROVIDER. I have pushed new changes with using @ngneat/storage

Sorry everyone for the delay.

va-stefanek avatar Nov 17 '21 21:11 va-stefanek

ya I'm looking for this feature still waiting :D

hiepxanh avatar Nov 18 '21 02:11 hiepxanh

@va-stefanek sure

NetanelBasal avatar Nov 20 '21 19:11 NetanelBasal