Oleksandr Zhevedenko

Results 13 comments of Oleksandr Zhevedenko

> Surefire and Failsafe run in two completely different Maven phases and also each in its own JVM, so it is to be expected that Spock is started once per...

>A possible future Spock improvement might be for global extensions to be able to indicate in which of the two phases they wish to be started so as to avoid...

From the end-user perspective, the whole global extension stuff should look like this: - _JUnit#discovery()_: - _Spock#discoveryStart()_ - like @kriegaex suggested, put any code that influences test discovery here (cases...

+1. The current implementation looks counter-intuitive.

Gentlemen, IAB updated the spec and changed the names of 2 fields: ``` regs.ext.dsa.required --> regs.ext.dsa.dsarequired regs.ext.dsa.transparency[].params --> regs.ext.dsa.transparency[].dsaparams ```

Support for this was released as part of https://github.com/prebid/prebid-server-java/releases/tag/2.10.0 The only deviation from this spec in PBS-Java is the use of the kebab-case instead of the snake_case: `privacy.dsa.gdpr_only` -> `privacy.dsa.gdpr-only`....

The workflow still fails on S3 unit tests: ``` Error: Errors: Error: S3ApplicationSettingsTest.getStoredDataReturnsErrorsForNotFoundImpressions:359 » Sdk Error: S3ApplicationSettingsTest.getStoredDataReturnsErrorsForNotFoundRequests:329 » Sdk Error: S3ApplicationSettingsTest.getStoredDataShouldReturnFetchedStoredImpression » ClassCast Error: S3ApplicationSettingsTest.getStoredDataShouldReturnFetchedStoredImpressionAndStoredRequest » ClassCast Error: S3ApplicationSettingsTest.getStoredDataShouldReturnFetchedStoredImpressionWithAdUnitPathStoredId »...

Hello, @dzesm . This is weird, as PBS doesn't use a default request unless you explicitly enable it. So unless you provided the default request, nothing should be added to...

@And1sS please chime in on this one as you had some ideas about the implementation. Plus I propose one change right off the bat: instead of using static wait time,...

I want to add a proposal to add a sampling in addition to the feature toggle. So only a certain configurable % of requests for any given account will have...