lecter icon indicating copy to clipboard operation
lecter copied to clipboard

Improve frontend performance on diagnosis page

Open gambala opened this issue 3 years ago • 5 comments

Tested this lib in one of my production ready project, and for some reason I see 1163 files on diagnosis page. Overall page performance (scrolling and interacting with file collapsing nodes) can be improved – by reducing amount of DOM nodes, CSS repaint hacks, removing heavy js events, etc

gambala avatar Jan 28 '22 20:01 gambala

Feel free to add me as a contributor and assign to this issue – will fix it

gambala avatar Jan 28 '22 20:01 gambala

I used ready-made templates. So yep, the frontend part required to be improved 😄

Feel free to add me as a contributor

As I know anyone could be a contributor. Please feel free to write me details

Neodelf avatar Jan 28 '22 21:01 Neodelf

Yeah I mean giving me a permission to push commits to master/main branch directly, without forking and PRs. The same process is in https://github.com/estum/russian_inflect for example

gambala avatar Jan 29 '22 01:01 gambala

I am not 100% sure about that approach. Yes, I've pushed commits to the master branch before promoted gem and before developers forked it. But now I wanna show all developers what we do in the codebase and where we follow. Is the work with a forked project not comfortable for you?

Neodelf avatar Jan 29 '22 10:01 Neodelf

Yes, but I understand your motivation too. Ok, let's try to do it canonical way, with forks and PRs

gambala avatar Jan 29 '22 11:01 gambala