Arthur Stolyar

Results 235 comments of Arthur Stolyar

In general seems fine. But why you use `scope` property? Here https://github.com/lukemarsh/redux-boilerplate/blob/master/web/webpack/config.prod.js#L43 it's not needed because it's deprecated and you already use `publicPath`. Here https://github.com/lukemarsh/redux-boilerplate/blob/master/web/webpack/config.prod.js#L35 it sets scope for ServiceWorker,...

Here is possible API design for it: https://github.com/NekR/offline-plugin/issues/117 Can you take a look? Would you be okay with it?

I think partial implementation somehow should go into v4, even though I planned to not really any version of it except for bug fixing. We have a problem of merging...

Also, I'm not 100% sure about the "full implementation". It's a bit different in `offline-plugin` than webpack itself, so maybe we'll end up using just a simple wrapper for all...

@TheLarkInn do you mind looking into this https://github.com/NekR/offline-plugin/pull/242? Seems like a thing related to this, so would be good to have a solution which fits both cases.

Hey. I'll look into ways of fixing failed registration. Thank you. Just FYI, Safari is unknown for its different issues, including weird behaviors for ServiceWorker and Cache Storage.

> It installs and it works ok for sometime, then it may just stop to update to new versions. After I manually clean up all the registrations (registration.unregister()) and reload...

Okay. So there might be multiple issues. There is this one: https://github.com/PWA-POLICE/pwa-bugs#problem-in-ios-12-cache-in-cache-storage-magically-disappears It supposed to be fixed in 12.2. Not sure why you're seeing it in 12.2. There is another...

Sounds weird, but unfortunately I don't have time to help you right now. Maybe next week.

How is it going? Were you able to fix the issue?