Arthur Stolyar

Hmm.. so it might be a webpack 4 thing 🤔Not sure what webpack accepted there previously. Well, if object works in 2-4 versions, then I can change that, no problem....

@mxstbr there were some changed is that part of the code, but mainly related to webpack 4. Have you just started using `hard-source-plugin` and got the error or you were...

@mxstbr okay, I see. Sounds like a long standing error. I'll check today what I can do, maybe I can fix it on my side. Thanks for ccing!

Unfortunately it cannot fix it on my side. Changing: ```js result.loaders.push( path.join(__dirname, 'misc/runtime-loader.js') + '?' + JSON.stringify(data) ); ``` to ```js result.loaders.push({ loader: path.join(__dirname, 'misc/runtime-loader.js') + '?' + JSON.stringify(data) });...

The only docs I can find about it are here: https://github.com/webpack/docs/wiki/plugins#normal-module-factorynmf-normalmodulefactory And it shows string usage in that case.

Well, here it seems to be transformed: https://github.com/webpack/loader-runner/blob/master/lib/LoaderRunner.js#L37 I do send it as: ```js result.loaders.push({ loader: path.join(__dirname, 'misc/runtime-loader.js'), options: JSON.stringify(data) }); ``` Seems to be working. It won't be working...

Well, `offline-plugin` for sure 😁 If serious, it depends by a multi-page website's design. Reasonable default might be app-shell + streaming it with content requested from the server (server responds...

@developit is it SPA? For SPA it's easier and `offline-plugin` indeed supports that use case. For multi-page.. A but trucker and there are possibly perf downsides on big projects (which...

@TheLarkInn yeah, that would great :-)

@addyosmani > After having tried to enable "offline by default" workflows in a few different CLI/starter kit projects over the last 2 years, I've come to the opinion that this...