Pratyay Banerjee

Results 70 comments of Pratyay Banerjee

@navendu-pottekkat please assign this to me.

@nfrankel +1 @navendu-pottekkat If it's up for grabs, I'd love to take it! :)

@navendu-pottekkat Sure! I think it's the same procedure that I did back in [#8724](https://github.com/apache/apisix/pull/8724), although I'm a bit confused about where these should be added. @nfrankel mentioned that we should...

@spacewander @navendu-pottekkat Can you assign me please if this is up for grabs?

@navendu-pottekkat I'm a bit confused about whether I'm going to break the tests by directly removing [`minimum = 0`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/apisix/schema_def.lua#L239) or we need to set the props to a minimum of...

Gotcha! Thanks for the clarity @spacewander 😄 I'm moving forward with assigning `minimum = 1` to [here](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/apisix/schema_def.lua#L239) instead of removing `minimum = 0` then. > I assume that we need...

Also getting this error msg: ![image](https://user-images.githubusercontent.com/48355572/229133735-846b5c23-1639-4dfb-918b-271544043938.png)

@rajaSahil are you still on it? If not we can collaborate. @kkourt If possible can you assign both of us? 😄

Update: As a newcomer, I've been trying my level best to get familiar with the codebase. Here's my [approach](https://github.com/Neilblaze/tetragon/blob/tetragon-Add-metrics-for-lru-cache-in-pkg/observer/data.go/pkg/observer/data.go) & the following changes can be observed [here](https://github.com/Neilblaze/tetragon/commit/62269a8beaedbdda5698aa9798a8bbf2adbc4200). Lemme know if...

@YTGhost fyi, I already had started working on it. You can inspect my previous comment for reference. I'm just waiting for feedback from @kkourt.