tetragon
tetragon copied to clipboard
Add metrics for lru cache in pkg/observer/data.go
would be good to add metrics for lru cache in pkg/observer/data.go
,
like we do in pkg/process/cache.go
so we can eventually watch and suggest better value for the cache
@kkourt Can I start working on this issue?
@rajaSahil I'm not aware of anyone working on it, so yes :)
@kkourt Thank you! Can you please assign it to me?
@kkourt Thank you! Can you please assign it to me?
Sure thing! Let me know if you need any help.
@rajaSahil are you still on it? If not we can collaborate. @kkourt If possible can you assign both of us? 😄
Update: As a newcomer, I've been trying my level best to get familiar with the codebase. Here's my approach & the following changes can be observed here. Lemme know if I need to update anything.
cc: @kkourt
Perhaps I can take on the job if the previous two have moved on from the issue.
@YTGhost fyi, I already had started working on it. You can inspect my previous comment for reference.
I'm just waiting for feedback from @kkourt.
@YTGhost But yeah, no worries! you can go ahead & raise a PR if you want.
Update: As a newcomer, I've been trying my level best to get familiar with the codebase. Here's my approach & the following changes can be observed here. Lemme know if I need to update anything.
cc: @kkourt
your links are private, please create a PR or a draft PR if you want someone to review your changes.
@mtardy Oh no! I just realized that I mistakenly force-pushed all the master content into the working branch, thus overriding the entire data. 😓
I'll have to check if I can recover it, but in the meantime, YTGhost can work on it.
Ok I'll unassign this for now. If anyone wants to take this.
question - what kind of metrics are expected to be added here? Is it about adding error metrics after cache eviction?