tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

Add metrics for lru cache in pkg/observer/data.go

Open olsajiri opened this issue 2 years ago • 13 comments

would be good to add metrics for lru cache in pkg/observer/data.go, like we do in pkg/process/cache.go

so we can eventually watch and suggest better value for the cache

olsajiri avatar Feb 02 '23 10:02 olsajiri

@kkourt Can I start working on this issue?

rajaSahil avatar Feb 10 '23 15:02 rajaSahil

@rajaSahil I'm not aware of anyone working on it, so yes :)

kkourt avatar Feb 10 '23 16:02 kkourt

@kkourt Thank you! Can you please assign it to me?

rajaSahil avatar Feb 10 '23 19:02 rajaSahil

@kkourt Thank you! Can you please assign it to me?

Sure thing! Let me know if you need any help.

kkourt avatar Feb 17 '23 08:02 kkourt

@rajaSahil are you still on it? If not we can collaborate. @kkourt If possible can you assign both of us? 😄

Neilblaze avatar Feb 26 '23 13:02 Neilblaze

Update: As a newcomer, I've been trying my level best to get familiar with the codebase. Here's my approach & the following changes can be observed here. Lemme know if I need to update anything.

cc: @kkourt

Neilblaze avatar Feb 26 '23 14:02 Neilblaze

Perhaps I can take on the job if the previous two have moved on from the issue.

YTGhost avatar Mar 30 '23 09:03 YTGhost

@YTGhost fyi, I already had started working on it. You can inspect my previous comment for reference.

I'm just waiting for feedback from @kkourt.

Neilblaze avatar Mar 30 '23 09:03 Neilblaze

@YTGhost But yeah, no worries! you can go ahead & raise a PR if you want.

Neilblaze avatar Mar 30 '23 09:03 Neilblaze

Update: As a newcomer, I've been trying my level best to get familiar with the codebase. Here's my approach & the following changes can be observed here. Lemme know if I need to update anything.

cc: @kkourt

your links are private, please create a PR or a draft PR if you want someone to review your changes.

mtardy avatar Mar 30 '23 10:03 mtardy

@mtardy Oh no! I just realized that I mistakenly force-pushed all the master content into the working branch, thus overriding the entire data. 😓

I'll have to check if I can recover it, but in the meantime, YTGhost can work on it.

Neilblaze avatar Mar 30 '23 17:03 Neilblaze

Ok I'll unassign this for now. If anyone wants to take this.

mtardy avatar Jan 15 '24 11:01 mtardy

question - what kind of metrics are expected to be added here? Is it about adding error metrics after cache eviction?

AshishNaware avatar Aug 21 '24 18:08 AshishNaware