Basic formatter discarding file, line and mfa

Open ppeerttu opened this issue 1 year ago • 2 comments

Hi! Thanks for a great library. Just wondering why does the LoggerJSON.Formatters.Basic discard the file, line and mfa information? To me it looks like it's impossible to configure the basic formatter to include them, and that's what I specifically would like to do.

Oct 03 '24 06:10 ppeerttu

Hi @ppeerttu. This is by mistake, a PR would be welcome. I believe all you have to do is to remove those three here and make a test that makes sure we don't have a regression: https://github.com/Nebo15/logger_json/blob/master/lib/logger_json/formatters/basic.ex#L22

Oct 08 '24 18:10 AndrewDryga

@AndrewDryga awesome, I'll make a PR as soon as I can, perhaps already this week.

Oct 10 '24 06:10 ppeerttu