Nathan Fradet

Results 60 comments of Nathan Fradet

Hi, Are you able to provide greater detail on to where (e.g. specific code line in specific file) and when it happens?

Ok great! Note sure what was fixed but I'll keep this on my mind if the issue ever occurs again.

Noted, let’s focus on the second one then! For ‘use_full_resolution’, as long as it can be implemented only in PerTok that’s possible

Hi, thank you very much for reporting this important bug! This should have been updated when the changing the `pitch_range` attribute from `range` to a tuple. I just opened a...

Thank you for the suggestion! Indeed, this could be a nice addition for bar-based tokenizers. I don't think this should be hard to implement. Would you be up to do...

Great! I don't think it's necessary to implement it for others, as they handle bars / times and notes altogether already so there is no real way to add trailing...

Thank you for the report! Maybe the DataCollator class can implement a method to return empty batches, that could be overridden by users to handle these use cases according to...

Hi, ty for the report! Would you be able to provide a short reproducible example in order to fix the cause of the issue?

Thank you for the feedback! I think the original issue occurs in the data collator when all the elements of the batch are `None`. In this case I’m not sure...

Hello, By midi sequence, are you referring to the original MIDI messages as they are written within a file? If that is the case, this lib isn't meant for this...