Nathan Fradet

Results 60 comments of Nathan Fradet

Just pushed it, I think it should do it 🙌

By overlapping sequences are you referring to chunks of music that would cover several portions of the same bars? E.g. `[b1, b2, b3]`, `[b2, b3, b4, b5]`, `[b4, b5, b6]`

That's a good idea, I'll add a `n_overlap` option to allow to MIDI chunks to overlap a few bars, this could enforce the "causality" throughout the entire MIDI. For BOS...

I think a good way is to add a MIDI marker at the first tick of each chunk. [Here is how I implemented it](https://github.com/Natooz/MidiTok/pull/148/files#diff-c3bb3af3bf9d80ae2bed99ff07e845974e282d263bbcd036a5ad862fa597f47cR132). And [here is in the DatasetMIDI](https://github.com/Natooz/MidiTok/pull/148/files#diff-a7676d6d02a679806d4332f76d098a8a9a1661746219653c618084e9a0f17916R204)...

Its in `DatasetMIDI._tokenize_midi` but linking the exact line might change with future commits, here is the code: ```Python # If this file is a chunk (split_midis_for_training), determine its id. #...

Chunk overlap is pushed, I'll have a few tests to do then and to modify the docs and we'll be good to merge! 🙌

Thank you for the note. For structured, the type of the first token (TimeShift of Pitch) isn't really important. If it starts with a Pitch, this means that a the...

Hi, The error seems to occurs when preprocessing a certain file (merging its tracks more exactly). Would you be able to either identify this specific file (printing its path in...

Thank you! It's quite large so I hope to catch it quickly and see how I'll handle this.

In the meantime if you want to fix the issue right now, you can just clone the repo, edit the problematic line in `merge_tracks` method in the miditok/utils/utils.py file to...