Nathan Zook

This PR addresses at least three different issues. As for the cause specified, please see my comment at https://github.com/arangamani/jenkins_api_client/issues/300#issuecomment-906206519

This is a wholly inadequate way to handle cookies. There are multiple places in the file where cookies need to be read--including another place in the above snippet. But beyond...

Scrolling through the issues, I hit this. I really cannot see how this is Psych's concern. Class.new calls klass.allocate.initialize. If klass.allocate returns nil, then many, many things are expected to...

I'm new to go, but I wondering about just wrapping the HTTP client with a logger. This runs into problems, and I think I know why: compare NewClient here &...

@mirosval @andredurao I've chased the rabbit hole a bit. Especially if you want a general solution, you want an http.Client where the Transport does the logging in RoundTrip (https://golang.org/src/net/http/client.go#L250). Keep...

Request.getBody is what is needed. This is used for 307 & 308 responses, as documented in Request.NewRequest (https://golang.org/src/net/http/request.go#L792)

Note that for testing and logging, as in https://github.com/shurcooL/githubv4/issues/36, it is not too hard to create a custom http.RoundTripper, and slide it into the http.Client that is fed to NewClient....

I just bumped into this with some Exception classes. To me, the *exception* to this rule is that the ancestors of a class do not initialize ivars. Of course, a...

I believe you are looking for https://godoc.org/go.uber.org/zap/internal/color.

But this is a real problem. We're promoting a standard log structure, and it includes things like adding the error under the key "error". What you want is to be...