Nathan Royer

Results 10 comments of Nathan Royer

I appended an empty section with that name to all asm files except `defines.asm` and the first warning disappeared; the second one remain.

> I thought we were just combining all the build-related `tools/` such that we don't have to pay the cost for compiling multiple separate tool crates? Yep, that's exactly what...

> [...] not necessarily transforming every step in the Makefile into a separate Rust program. But theseus-builder is just one program, they're not separate programs? If you prefer, we can...

This looks great! Have you thought about implementing the RngCore trait? Would that be a good thing? https://docs.rs/rand_core/latest/rand_core/trait.RngCore.html

Possible problem here: - gcc can use mold via `-fuse-ld=mold` - clang can use mold via `--ld-path=$(which mold)` However `mold` can work for both if it is used like so:...

Note: all file modifications with this icon: ![image](https://user-images.githubusercontent.com/61582713/197793124-50d7fc13-9d35-4a60-86cc-3122b97ae87c.png) are files that were simply moved without internal modification. I hope this simplifies your review.

Ok this is ready for a first review. I just added a command line toggle for USB emulation: `usb_hid=yes` (default=no).

While most of the core blocks of Theseus have been ported to AArch64, the framebuffer (and the rest of the graphics stack) hasn't fully been; the bootloader is responsible for...

Great, happy to hear that :ok_hand:

I was not able to fix the bug, however I found a workaround: setting `zeno::Join::Bevel` via [the `join` setter](https://docs.rs/zeno/latest/zeno/struct.Stroke.html#method.join) on a Stroke object prevents the buggy code to run.