Nateckert comments

Results 4 comments of


                                            Nateckert

"Code is Unreachable" is showed when code is actually working

Hi, I have a similar issue, but with context manager, that is reproducible with the following minimal example: ```python from contextlib import contextmanager class ContextManager: error_raised = False @contextmanager def...

Avoid usage of the non monotonic clock System.currentTimeMillis() in favor of System.nanoTime()

The comment https://github.com/testcontainers/testcontainers-java/pull/6392/files#diff-1cb71d0ebd85bd607c3da0c4e693f353e5d0b9c947a2396ffc32042f3ccbb63eL45 is now incorrect, but a good estimate is hard to guess

Avoid usage of the non monotonic clock System.currentTimeMillis() in favor of System.nanoTime()

> Thanks for providing a PR @Nateckert. Is this an issue you have observed in your system while using Testcontainers? > > Could you please run `./gradlew :database-commons:spotlessApply` to fix...

Avoid usage of the non monotonic clock System.currentTimeMillis() in favor of System.nanoTime()

> The comment https://github.com/testcontainers/testcontainers-java/pull/6392/files#diff-1cb71d0ebd85bd607c3da0c4e693f353e5d0b9c947a2396ffc32042f3ccbb63eL45 is now incorrect, but a good estimate is hard to guess With the changes after @jtnord's feedback, I managed to update the estimate