NatashaKnk

Results 9 comments of NatashaKnk

The error I'm getting is "error: failed to legalize operation 'mhlo.scatter' that was explicitly marked illegal", and the output scatter op is: ``` %13798 = "mhlo.scatter"(%49, %261, %13797) ({ ^bb0(%arg4:...

What seems to happen is that the folder fails on casting the scatter_dimension attribute (i.e. %arg1: tensor) to a DenseIntElementsAttr. I'm not exactly sure why that would be the case...

Yeah, sorry! As far as I understand it returns false [here.](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc#L7509)

I'm on it, fix should be in today/tomorrow

Sorry for the delay! Should be fixed when [10095](https://github.com/iree-org/iree/pull/10095) is submitted.

Just to make sure, this and [10291](https://github.com/iree-org/iree/issues/10291) are associated with newly-added models, correct? We didn't support dynamic non-batch dims for those ops (based on our conservative approach for dynamic dim...

Should be fixed in [D133389](https://reviews.llvm.org/D133389).

Should be fixed with [10534](https://github.com/iree-org/iree/pull/10534), closing this.

By local testing, do you mean more extensive testing than exists here? Where should this be added if so?