Nathan Roach

Results 8 comments of Nathan Roach

Not sure what to do about these timeouts in the tests, but it seems like the ubuntu test that failed in `f904e79` passed in `90875c3`, and the mac os test...

Absolutely. Just wanted to make sure that the approach looked reasonable to you before moving forward on writing tests. I'll try to get that done ASAP.

I'm not really sure what's going on with the test that's failing. I didn't change anything related to the code for updating dependencies, and that test is failing for me...

@mariusvniekerk I think this is passing all CI except the test that seems to be failing on main / other branches as well. Happy to add more tests if you'd...

@mariusvniekerk @jezdez I believe this should be ready for re-review. I think I've addressed your comments. Apologies for delay.

Hi @mariusvniekerk , @jezdez, et al. Just pinging again to remind that this could use another review whenever you get the chance.

Hi @mariusvniekerk @jezdez , just wanted to ping about this one more time as I believe it's ready for re-review when you get the chance.

@mariusvniekerk @maresb I believe I've addressed the remaining comments you had. Sorry for the delay on that. Please let me know if there's anything else you'd like to see to...