Robin Salen
Robin Salen
The current implementation / test suite implicitly assume that the TWO_ADICITY is upper bounded, and fits in one limb of the field element, or it will fail ([this assertion](https://github.com/arkworks-rs/algebra/blob/344b27d4ae02b0c9f4bd3e377aff4c9aee73dd46/test-templates/src/fields.rs#L308) in...
Hi guys! Super cool work you're doing! I saw cleopatra was supporting only the equivalent of cairo-run at the moment. Do you envision supporting as well compilation of cairo programs...
The Cairo paper stipulates that the prime to be used needs to be greater than 2^63 (i.e. be of 64 bits at least), for proper instruction decoding. This check is...
The starky crate doesn't have much unit tests, and would benefit from a stronger test suite covering the different setups that can be used.
In a bunch of cases, we could reduce the serialization overhead by storing smaller primitive types than `usize` as the underlying values have to be small (~`u8`). Additionally, there may...
The `starky` crate exposes `CompressedStarkProof` and `CompressedStarkProofWithPublicInputs` without any associated implementation. We should decide whether to - remove them from the public API - address the associated TODO in `starky/src/get_challenges.rs`...
In the Key Generation process, part 2 step 2, the participant is checking every received commitments from other participants. This is being done as below: https://github.com/isislovecruft/frost-dalek/blob/9645caf8f2dd881b8bc7b62edc8a048344b71630/src/keygen.rs#L551-L555 However, the indices in...
# Description Adds missing test scenarios to ensure edge cases are covered. ## PR Checklist: - [x] I have performed a self-review of my code - [x] I have commented...
Related to the item mentioned in #28, we would probably need additional sanity checks on the resharing phase. There also needs to be a clear line drawn between what the...
We're lacking of coverage on the DKG / resharing side with respect to the different entry doors for malicious participants. We also need some test case of `DKG -> resharing...