Narishma-gb

Results 8 comments of Narishma-gb

I have started adding the Japanese ROMs at https://github.com/Narishma-gb/pokeyellow-jp Currently building only Rev.0, other revisions and VC patch will follow. The ROM is mostly identical to its Western counterparts, minus...

Can you pass two optional arguments to a macro? How can we find out what is `\1`?

I see, thank you! On a side note, I would like to propose a simplification of `_redef_current_label`. Currently it computes the total number of arguments, to fetch the last one...

The crash seems to be caused by an oversight in `DisplayListMenuIDLoop`, during the call to `GetName`. https://github.com/pret/pokered/blob/59da8c8122ebb8fcc334d4e5421e4fb333eea730/home/list_menu.asm#L142-L148 When pressing A inside a list menu, the selected entry name is copied...

This is referenced in another issue (#315): > * Rename early labels to be more accurate (e.g. `MissableObjects`, which are not just for missables) I agree with Vortyne, HideShow is...

Something else to note when refactoring Makefile: `make clean` does not remove `rgbdscheck.o` On Unix, direct execution of python scripts could fail due to permissions errors, perhaps add `$(PYTHON)` ?

> `make tidy` and `make clean` do remove rgbdscheck.o in pokered and pokecrystal, and it would defeat the purpose of rgbdscheck if an outdated .o file sticks around, so it...