Jonas Pauthier

Results 165 comments of Jonas Pauthier
trafficstars

I just discovered Monaspace and as many other I'm excited to give it a try but to discover that the ecosystem might not have caught up yet to use it...

@glasser If we didn't use the `context` function before and added one only to handle the case raised by OP, is there a specific return to do or can we...

I believe last time we had a discussion regarding testing we advocated for integration tests through `server.inject` rather than unit testing. Regarding the way you'd structure the separation is up...

Right now I believe `joi` supports node version down to v12 as you can see here: https://github.com/hapijs/joi/issues/2262. However once v18 lands, it will drop v12 support: https://github.com/hapijs/joi/issues/2926

@Marsup what do you think of adding `engines.node` to `joi`'s package.json to easily communicate the supported `node` versions?

> Do you mean that it supports any node version v12 and above at this moment? Which means it should support v18 right? You can safely assume that it supports...

I'm pretty sure it supports node@18. Do you have an issue with node@18 that makes you think otherwise?

@JustCasuallyJames if you look at the tests run on GitHub actions: https://github.com/hapijs/joi/actions/runs/6408115210 all tests pass for node@18 and node@20 so the support extends to node@20 as well.

Do you mind sharing your error and some code perhaps if needed so we can better understand what's the problem you're facing?