Jonas Pauthier

After another fresh look, I think this feature would be a nice addition. I understand there is a workaround but I don't feel this feature is big enough that it...

I believe this is a valid feature request. Even though you could throw a `Boom.badRequest` error as Eran mentioned you lose the message generated by Joi for the `defaultError`. This...

Good idea @devinivy . I didn't think of this one. Would you consider it a transitional step before a breaking change or the final implementation? Thanks @sholladay . Interesting stuff...

I think that it seems like an interesting feature but I feel this would probably require some heavy work in the codebase. I'm not sure of how wide the changes...

Your suggestion about protobuf rings a bell and remind me about a vision that Eran expressed a while back and that the TSC shares regarding hapi becoming protocol agnostic rather...

I think you're right. If I understood correctly as well, when we call `hmacWithPassword` we're calling another time `generateKey`: https://github.com/hapijs/iron/blob/62e00b64bd405a2c8bc773328774da9f7cc92d3c/lib/index.js#L156 which is where we create `keyI` using `saltI`. Since we're...

Thanks @kanongil for bringing this up. Overall this seems like a good idea, I'm not sure though regarding breaking the support for the Chrome use case. Reading through the PR...

Per [GH documentation](https://docs.github.com/en/rest/overview/permissions-required-for-github-apps#permission-on-contents) I don't think we even need the GH token `contents: read` access. I revoked all permissions to the GH token and kept only the `meta: read` (default)...

Good catch, thanks @kanongil.

Thanks for the examples Gil. I believe Eran already used private class methods somewhere in the org already.