Michal Waligora
Michal Waligora
Any progress?
Sounds like a nice QOL improvement. I'm working on an initial implementation.
Is there anything major preventing this from being merged? I merged this patchset into my personal config and everything works fine.
Is the rewrite still happening? The `rewrite` branch hasn't been touched in quite a while (9 months).
No problem. I'm happy to help in any way that I can. I created FFI bindings to freerdp3 as that seems a better solution to using external processes everywhere: https://github.com/NaniNoni/freerdp-sys....
> looks good! > > Please add a test though, you can look at > > application/testing/CMakeLists.txt:1101 > > `TestCommandScriptPrintScene` and copy the logic. Thank you, will do
I fixed/implemented the requested changes. However, in the loop over canonical paths, I ended up using `debug` instead of `print(logLevel, ...)` due to the large amount of unwanted output when...
> Would it be better to improve the separation of concerns between `GetConfigPaths` and `ReadConfigFiles` instead of trying to include the user-facing logging into `ReadConfigFiles` with a dry-run param? >...
I implemented the requested changes. The only downside I'm aware of is that the `print_config_info` command considers `"config"` as the only `configSearch` query for `GetConfigPaths`. I think this may cause...
> I'm confused by this implementation. It looks to me this will not output anything about config files now ? We want the same or at least a similar output...