Denis Blank
Denis Blank
Very nice stuff i think
I was able ro reproduce the issue see the following stacktrace how `minalign_` gets set to 12: ``` flatbuffers::FlatBufferBuilder::TrackMinAlign(unsigned __int64 12) Line 250 C++ flatbuffers::FlatBufferBuilder::PreAlign(unsigned __int64 108, unsigned __int64 12)...
@dbaileychess Could you review this PR please? I fixed the issue by adding alignment parameters to functions calling StartVector. Additionally, I spotted several expressions in the codebase of the form...
@dbaileychess Thank you for your review, I have fixed the outstanding changes and optimizations.
@dbaileychess From my side this PR is finished, do you know why workflow "buildkite/flatbuffers/pr" is failing without any useful output?
@dbaileychess I probably have fixed the remaining issues, could you approve the outstanding workflows again please?
https://godbolt.org/z/nW317o73E ```cpp #include #include #include #include #include using namespace entt; void test() { ranges::zip_view(ranges::views::iota(1), ranges::views::iota(1)) | ranges::views::filter([=](auto&&) { return true; }); } ``` After reproducing the issue I noticed that...
I have no idea. Actually I expected the issue to occur without `using namespace entt` too.
Thank you for taking a look at this again. I see your point, however importing namespaces can be perfectly valid especially for compilation units (not headers). It is probably difficult...
As I remind, the in-class `operator!=` also fixed the issue for me. A catch-all constructor is always fine as long as it is marked as `explicit`. I was saying that...