curobo icon indicating copy to clipboard operation
curobo copied to clipboard

Fix repeated application of scale to velocity joint limits

Open scharalambous-sony opened this issue 1 year ago • 3 comments

  • Resolves issue where velocity scale is applied 2x to the velocity joint limits
  • Adds a corresponding unit test

scharalambous-sony avatar May 06 '24 14:05 scharalambous-sony

Thanks for this fix, let me go through the MR to understand why scale was being applied twice.

balakumar-s avatar May 06 '24 16:05 balakumar-s

Thanks for this fix, let me go through the MR to understand why scale was being applied twice.

The reason is that the velocity scale is applied here https://github.com/NVlabs/curobo/blob/7196be75f5294f0997a2b55ed9f24a088d57b33e/src/curobo/cuda_robot_model/cuda_robot_generator.py#L976 and here https://github.com/NVlabs/curobo/blob/7196be75f5294f0997a2b55ed9f24a088d57b33e/src/curobo/cuda_robot_model/types.py#L200

scharalambous-sony avatar May 07 '24 09:05 scharalambous-sony

I have updated the PR with a more foolproof implementation. The clipping and scaling operations are now member functions of JointLimits and we can now keep track of whether they've been already applied

scharalambous-sony avatar May 10 '24 14:05 scharalambous-sony