kaolin icon indicating copy to clipboard operation
kaolin copied to clipboard

Translate transform for pointclouds

Open pushkalkatara opened this issue 5 years ago • 6 comments

This PR solves issue #250

pushkalkatara avatar May 08 '20 14:05 pushkalkatara

The build is failing at weird error -


/opt/conda/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
--
831 | #warning "Using deprecated NumPy API, disable it with " \
832 | ^
833 | imagecodecs/_aec.c:602:20: fatal error: libaec.h: No such file or directory
834 | compilation terminated.
835 | error: Setup script exited with error: command 'gcc' failed with exit status 1

maybe adding apt-get install libaec-dev would solve build error

pushkalkatara avatar May 09 '20 23:05 pushkalkatara

Hi @krrish94 , @Caenorst This transform is a preprocessing function for semantic segmentation in DGCNN pipeline. Please review the PR.

pushkalkatara avatar May 15 '20 19:05 pushkalkatara

Hi @pushkalkatara , I think the error that you faced might be due to recent numpy release, we fixed it in #262 can you rebase and force push ?

Caenorst avatar May 15 '20 19:05 Caenorst

Thanks for pointing out @Caenorst Now the build is passing :D

pushkalkatara avatar May 15 '20 22:05 pushkalkatara

Hi @Caenorst Thanks for the detailed review. I have made some changes in the recent commit and added questions as well. please review once again. Thanks.

pushkalkatara avatar May 16 '20 09:05 pushkalkatara

Sorry, forgot to confirm the review :/

Caenorst avatar Jun 01 '20 14:06 Caenorst