kaolin icon indicating copy to clipboard operation
kaolin copied to clipboard

Atlasnet pr

Open ThibaultGROUEIX opened this issue 5 years ago • 4 comments

Signed-off-by: ThibaultGROUEIX [email protected]

Description

Add AtlasNet ImageRecon example

Tests

python train.py --shapenet-root /data/ShapeNet --shapenet-images-root /data/ShapeNetRendering
python eval.py --shapenet-root /data/ShapeNet --shapenet-images-root /data/ShapeNetRendering

Using:

Ubuntu 18.04 Titan X Pascal

ThibaultGROUEIX avatar Mar 17 '20 11:03 ThibaultGROUEIX

Hi @wenzhengchen, Thanks for your review! I didn't understand if you wanted me to do the changes or if you were asking if you could modify the PR. In the latter, feel free of course! In the former, it might take a while i don't have much time these days, Best regards, Thibault

ThibaultGROUEIX avatar Apr 16 '20 08:04 ThibaultGROUEIX

Hi Thibault,

flake8 is currently having a lot of excluded files (because we added it after the project was realised and we didn't want to overwhelm the CI), what needs to be done is to remove your new files from the exclude list in .flake8 and then fix the errors / warnings which will be displayed in the CI.

In case you are way to busy and cannot contribute further we can start to contribute to the PR, but only if you want us to as you may want to keep full ownership of the PR.

Best, Clement

Caenorst avatar Apr 21 '20 17:04 Caenorst

Hi Clément, I happy for you to contribute to the PR, i have become too busy :( Best, Thibault

ThibaultGROUEIX avatar Apr 21 '20 22:04 ThibaultGROUEIX

@ThibaultGROUEIX Thanks for the heads-up!

krrish94 avatar Apr 21 '20 22:04 krrish94

Code refers to outdated version of the library; closing merge request.

shumash avatar Feb 27 '25 16:02 shumash