FMS
FMS copied to clipboard
NOAA-GFDL
GFDL's Flexible Modeling System
**Is your feature request related to a problem? Please describe.** get_grid_version_1 and 2 have an argument for compute domain indices, but then queries the domain for global and compute indices....
**Is your feature request related to a problem? Please describe.** The coupler types module has a send_data routine to iterate through its fields and call send_data. This has no real...
**Describe the bug** Theres null pointer variables used in the coupler types module: https://github.com/NOAA-GFDL/FMS/blob/61cc3b9fd3b6978c2e0b383cc45831e4b2745919/coupler/coupler_types.F90#L1496 https://github.com/NOAA-GFDL/FMS/blob/61cc3b9fd3b6978c2e0b383cc45831e4b2745919/coupler/coupler_types.F90#L1586 **To Reproduce** n/a **Expected behavior** these should be removed **System Environment** n/a **Additional context** came...
**Describe the bug** In astronomy_end there is no allocation check before the deallocation of module variables: https://github.com/NOAA-GFDL/FMS/blob/61cc3b9fd3b6978c2e0b383cc45831e4b2745919/astronomy/astronomy.F90#L1977-L1985 **To Reproduce** n/a **Expected behavior** checks should be added for the deallocations **System...
**Describe the bug** the newest oneapi version crashes during compilation of fms2_io (netcdf_io.F90 more specifically) if you are using the `-check` flag. This is mainly for tracking until intel fixes...
**Description** This PR removes redundant public statements in _field_manager_mod_ and _fm_util_mod_ Fixes #1244 **How Has This Been Tested?** Make successfully runs with Intel and GCC on the AMDBox. The unit...
**Is your feature request related to a problem? Please describe.** The current mixed precision support for cmake creates two librarys fms_r4 and fms_r8 for the different defaults. With full mixed...
**Description** This PR removes the subroutine _fms2io_init_ . All code in _fms2io_init_ is involved in initialization and is moved to subroutine _interpolator_init_ instead. Fixes #1309 **How Has This Been Tested?**...
**Is your feature request related to a problem? Please describe.** In `interpolator_mod`, the subroutine _interpolator_init_ **mainly** calls the subroutine _fms2io_interpolator_init_. The code under _fms2io_interpolator_init_ does not need to be in...
**Description** adds 2 missed aliases in libFMS.F90 that slipped through with the last update. Fixes #1288 (thanks Lauren for spotting these!) **How Has This Been Tested?** CI **Checklist:** - [x]...