Pedro González Serrano
Pedro González Serrano
It's allowed on Varnish 4, nevertheless there is an update on the way to make it compatible with varnish 5
Rel #1032 Any updates on this?
@usp-rol for what it's worth we have been using this code (along with #1164 & #1146) for months in several clients without any issues
I don't know why "Puppet 6 - Ubuntu 18.04" acceptance is failing but AFAIK it seems related with elastic_stack module and this PR is working as expected
Hi @bastelfreak , thanks to all of you for taking over with this module! Most code is copied/adapted from other parts of the module so I hope my bits are...
Thanks, I'm now confident enough to try to reroll #1102 and #1103 adding tests
Removed some leftover todos, add more tests, and fixed some comments. Any chances for this to be merged soon?
Test fail seems unrelated/accidental, but I've no idea of how to re-run test without force-pushing
I think the condition only has sense in stats, you'll probably want status of `all_containers` Regarding list comprehension... I don't use to code python so I just googled, landed on...
@sumpfralle converted to a list comprehension and tested. BTW: It seems that [all_containers should already be doing the filtering](https://github.com/munin-monitoring/contrib/blob/master/plugins/docker/docker_#L148)... but my brand new python skills gime me no idea of...